[CI] Optimise PR previews deployments by sharing resized images #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an attempt to get faster PR preview deployments, by using a single folder of resized images (gh-pages resized/ root folder) and symlinks for each PR preview build.
ogizanagi
force-pushed
the
optilm-pr-preview-resized-img
branch
from
d679b21
to
d9ea5d1
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2024
for commit a0dd378
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2024
for commit 1216e7f
…o reach parent staging deployment
ogizanagi
force-pushed
the
optilm-pr-preview-resized-img
branch
from
a5cb08b
to
5da3cd0
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2024
for commit c39facc
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2024
for commit 7a188aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an attempt to get faster PR preview deployments, by using a single folder of resized images (gh-pages resized/ root folder)
and symlinks for each PR preview build.Important
Actually, Github builds the archive during the "pages build and deployment" by using
--dereference --hard-dereference, so using symlinks does not save us anything regarding the deployment… 😢https://github.com/orgs/community/discussions/9104
So, instead, tweaks the app so we can configure the base URL to use for resized images. Hence, we can use relative
../../resizedbase path to re-use the staging directory for PR previews (deployed to/pr/{number}). 🎉