add CheckDigit for DPD #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfebrero
force-pushed
the
add-check-digit-for-dpd
branch
from
1f91338
to
6839132
Compare
|
hmm, it's weird that DPD doesn't actually send out tracking numbers with check digits. even if you enter a tracking number with a bad check digit in their website, they just ignore it. for other carriers the check digit is always included. |
|
i wonder if we can match tracking numbers based on the depot code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lyleunderwood it seems users are not inputting the CheckDigit in elastic - the Check appears on the website but not in our database, at least not scramble side. Note the "B" in the screenshot.
Edit: screenshot for verification purposes - it should match the file change.