Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 馃幐 async plugin init #70

Merged
merged 6 commits into from Oct 27, 2020
Merged

feat: 馃幐 async plugin init #70

merged 6 commits into from Oct 27, 2020

Conversation

nickreese
Copy link
Contributor

@halafi The tests break for Elder.ts. It also seems we should be testing against the new plugin.ts. Can you take a peek?

@nickreese nickreese requested a review from halafi October 26, 2020 16:20
@nickreese nickreese mentioned this pull request Oct 26, 2020
Closed
thisislawatts
thisislawatts reviewed Oct 26, 2020
View reviewed changes
src/Elder.ts Outdated Show resolved Hide resolved
halafi
halafi reviewed Oct 27, 2020
View reviewed changes
src/utils/plugins.ts Outdated Show resolved Hide resolved
@nickreese nickreese linked an issue Oct 27, 2020 that may be closed by this pull request
Async Plugin Init #69
Closed
@nickreese nickreese merged commit b19dba3 into master Oct 27, 2020
@nickreese nickreese deleted the async-plugin-init branch October 27, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisislawatts thisislawatts thisislawatts left review comments

@halafi halafi halafi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async Plugin Init
3 participants
@nickreese @thisislawatts @halafi