Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-images] Custom fileTypes config is ignored in processImages function #119

Closed
noxasch opened this issue Jun 17, 2021 · 2 comments
Closed

Comments

@noxasch
Copy link
Contributor

noxasch commented Jun 17, 2021

This result in its using the default config neglecting user config.

For example if i set additional fileTypes as empty string,

config: {
    fileTypes: [''], // file types in addition to jpeg/png
}

The plugin will still generate webp image ignoring the config.

I already fixed in my fork, but i'm not sure if it's a bug or intentional. I can make a PR for a quick fix.

@nickreese
Copy link
Contributor

nickreese commented Jun 17, 2021

Wasn’t intentional. Definitely a side effect of porting my internal tool to the plugin. :) Happy for a PR. (You’re crushing it man)

The important thing I think is that it does the original file format + webp. So maybe the file array documentation should explain that? No reason to generate a jpg of a png when it might have a transparent background.

@noxasch
Copy link
Contributor Author

noxasch commented Jun 17, 2021

@nickreese aha, will do.

noxasch added a commit to noxasch/plugins that referenced this issue Jun 17, 2021
noxasch added a commit to noxasch/plugins that referenced this issue Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants