Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/ev testing #372

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Task/ev testing #372

merged 7 commits into from
Jul 13, 2023

Conversation

SteveMaier-IRT
Copy link
Collaborator

Issue

Link your PR to an issue

Fixes #___

Description

Please describe your pull request.

Testing

Describe the best way to test or validate your PR.

@SteveMaier-IRT SteveMaier-IRT merged commit 8b5d308 into main Jul 13, 2023
14 of 16 checks passed
@SteveMaier-IRT
Copy link
Collaborator Author

John and I discussed merging this before the review.

@@ -2,6 +2,7 @@
using System.Text.Json;
using CommunityToolkit.Maui.Storage;
using CommunityToolkit.Mvvm.Input;
using ElectionGuard.Ballot;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded using

{
ErrorMessage = string.Empty;
#if DEBUG
ErrorMessage = $"{Tally.State.ToString()} ran";
Copy link
Collaborator

@john-s-morgan john-s-morgan Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use localTally

{
ErrorMessage = string.Empty;
#if DEBUG
ErrorMessage = $"{Tally.State.ToString()} ran";
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need this

Copy link
Collaborator

@john-s-morgan john-s-morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

@SteveMaier-IRT SteveMaier-IRT deleted the task/ev-testing branch August 29, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants