Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃梻. SubmittedBallot should serialize a readable state not number #222

Open
1 task done
keithrfung opened this issue Feb 16, 2022 · 0 comments
Open
1 task done

馃梻. SubmittedBallot should serialize a readable state not number #222

keithrfung opened this issue Feb 16, 2022 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@keithrfung
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Suggestion

SubmittedBallot.state: BallotBoxState is encoded as a number. This is the only place that indicates whether the ballot is cast or spoiled and is only a 0 or 1. Would be disastrous for this to be misinterpreted.

Possible Implementation

Recommend that it be the name of the enum to remove ambiguity and language dependence.

Anything else?

Original Issue by @JohnLCaron
Election-Tech-Initiative/electionguard-python#522
@keithrfung keithrfung added enhancement New feature or request triage Waiting to be triaged labels Feb 16, 2022
@keithrfung keithrfung added question Further information is requested and removed triage Waiting to be triaged labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keithrfung