Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 SchnorrProof challenge specification and implementation do not match #253

Open
1 task done
JohnLCaron opened this issue Apr 13, 2022 · 1 comment
Open
1 task done
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@JohnLCaron
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Specification 1.0 for SchnorrProof (p 10, p 27) has the challenge as

c i,j = H(Q, K i,j , h i,j )

But implementation make_schnorr_proof in schnorr.py. line 89 has

c = hash_elems(k, h)

This was discussed in

Election-Tech-Initiative/electionguard-python#278

and it was decided to leave out the Q.

Expected Behavior

The specification should be amended after reviewing the decision to leave out the Q.

Steps To Reproduce

No response

Environment

- OS:

Anything else?

The 2.0 document being circulated "Proofs in ElectionGuard– changes for version 2.0" section 2 should also be amended.

@JohnLCaron JohnLCaron added bug Something isn't working triage Waiting to be triaged labels Apr 13, 2022
@keithrfung
Copy link
Collaborator

CC @benaloh

@keithrfung keithrfung removed the triage Waiting to be triaged label May 13, 2022
@colleenirt colleenirt added the question Further information is requested label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants