Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating samples and schemas for version 1.91 #332

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

SteveMaier-IRT
Copy link
Collaborator

Issue

Fixes #331

Description

Updated the schema files creating ones that did not exist yet.

Ran election using Hamilton sample manifest and added the election record.

Testing

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for condescending-wing-076a38 ready!

Name Link
🔨 Latest commit 805edd8
🔍 Latest deploy log https://app.netlify.com/sites/condescending-wing-076a38/deploys/65146a181bb87400085da854
😎 Deploy Preview https://deploy-preview-332--condescending-wing-076a38.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@john-s-morgan john-s-morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question on naming.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be challenge ballot schema?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would/should be but then we should also name the folder in the election record as challenged and this is not changing at this point.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can we correctly spell schema?

@john-s-morgan
Copy link
Collaborator

Lgtm

john-s-morgan
john-s-morgan previously approved these changes Sep 27, 2023
Copy link
Collaborator

@rc-egosi rc-egosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Thank you!

@rc-egosi rc-egosi merged commit 31bff14 into main Sep 27, 2023
6 checks passed
@rc-egosi rc-egosi deleted the task/update-1.91 branch September 27, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Schema and Sample Update
3 participants