Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scaffold] Request ZEC Form #135

Closed
geffenz opened this issue Dec 15, 2021 · 5 comments · Fixed by #221
Closed

[scaffold] Request ZEC Form #135

geffenz opened this issue Dec 15, 2021 · 5 comments · Fixed by #221
Assignees
@ccjernigan @geffenz

Comments

@geffenz
Copy link

geffenz commented Dec 15, 2021 •
edited by ccjernigan
Loading

As a user I would like to create a payment request so that I can request payments in ZEC and share them through default share channels offered by the operating system or as a QR code on screen

acceptance criteria:

  • the request follows the ZIP-321 specification
  • The request screen offers the user the ability of displaying it as a QR.
  • The request screen form common components with the send form
  • The user can opt to send the request as zero-value transaction to a given address through QR code (or address book if available) or pasting it into the recipient textfield.

A followup issue for this is #202, which implements the ability for the app to open these Zec requests.
@geffenz
Copy link
Author

geffenz commented Dec 20, 2021

image.png

https://xd.adobe.com/view/5eb728b7-cb5e-46d0-ac4d-5f3369faa82f-0be4/

@pacu
Copy link
Contributor

pacu commented Dec 27, 2021

@geffenz wouldn't "create and share" be a better term? Since this form is pretty similar to the send flow, the user might be confused by the word "send"

@pacu
Copy link
Contributor

pacu commented Dec 27, 2021

@geffenz How would users requesting ZEC in person to others share the resulting QR code?

ccjernigan added a commit that referenced this issue Dec 28, 2021
@ccjernigan
[#12] Home screen scaffold
fcc867f 
This provides a very basic scaffold of the home screen and navigation to other child screens.  Additional work needs to be done in both the SDK and this app to build all of the functionality.  Specific known gaps
 - Displaying synchronization status to the user, pending full designs on the progress and animation behaviors
 - Improved APIs for listing and filtering transactions.  This is the issue in the SDK Electric-Coin-Company/zcash-android-wallet-sdk#242
 - Implement the UI for displaying transaction history
 - Display fiat currency values
 - Hook up buttons to navigate to other screens (scan #137, profile #145, send #134, request #135)
@ccjernigan ccjernigan mentioned this issue Dec 28, 2021
Merged
15 tasks
ccjernigan added a commit that referenced this issue Dec 29, 2021
@ccjernigan
[#12] Home screen scaffold (#158)
205344c 
This provides a very basic scaffold of the home screen and navigation to other child screens.  Additional work needs to be done in both the SDK and this app to build all of the functionality.  Specific known gaps
 - Displaying synchronization status to the user, pending full designs on the progress and animation behaviors
 - Improved APIs for listing and filtering transactions.  This is the issue in the SDK Electric-Coin-Company/zcash-android-wallet-sdk#242
 - Implement the UI for displaying transaction history
 - Display fiat currency values
 - Hook up buttons to navigate to other screens (scan #137, profile #145, send #134, request #135)
ccjernigan added a commit that referenced this issue Feb 1, 2022
@ccjernigan
[#135] Request ZEC
b17b762
@geffenz
Copy link
Author

geffenz commented Feb 7, 2022

Lets change the action to "create and share" which shares only a link. In the future we may have two options "Share as email" or "share as text" so we could create a QR to increase usability.

@geffenz
Copy link
Author

geffenz commented Feb 7, 2022

Great call out with Carter. Let's remove the to field for now, as a user would be selecting their recipient from the share drawer.

ccjernigan added a commit that referenced this issue Feb 16, 2022
@ccjernigan
[#135] Request ZEC scaffold
d3dede1
@ccjernigan ccjernigan linked a pull request Feb 16, 2022 that will close this issue
[#135] Request ZEC scaffold #221
Merged
15 tasks
ccjernigan added a commit that referenced this issue Feb 16, 2022
@ccjernigan
[#135] Request ZEC scaffold
6fe7fa3
ccjernigan added a commit that referenced this issue Feb 17, 2022
@ccjernigan
[#135] Request ZEC scaffold
a1199e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccjernigan ccjernigan

@geffenz geffenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#135] Request ZEC scaffold Electric-Coin-Company/zashi-android
3 participants
@pacu @ccjernigan @geffenz