Skip to content

Commit

Permalink
Remove logs stripping check entirely (#1444)
Browse files Browse the repository at this point in the history
- As ensuring the check should be applied is not possible for a library that depends on clients build type and their different use cases
- Stripping tested manually with different client wallets, and it works as expected
  • Loading branch information
HonzaR committed Apr 17, 2024
1 parent 1833e86 commit 2a3c070
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions sdk-lib/src/main/java/cash/z/ecc/android/sdk/Synchronizer.kt
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,6 @@ interface Synchronizer {

validateAlias(alias)

validateLogging()

val saplingParamTool = SaplingParamTool.new(applicationContext)

val loadedCheckpoint =
Expand Down Expand Up @@ -741,10 +739,3 @@ private fun validateAlias(alias: String) {
"characters and only contain letters, digits, hyphens, and underscores."
}
}

private fun validateLogging() {
if (BuildConfig.BUILD_TYPE == "release") {
// In release builds, logs should be stripped by R8 rules
Twig.assertLoggingStripped()
}
}

0 comments on commit 2a3c070

Please sign in to comment.