Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and standardize SDK exceptions #1484

Open
3 tasks
HonzaR opened this issue May 31, 2024 · 0 comments
Open
3 tasks

Validate and standardize SDK exceptions #1484

HonzaR opened this issue May 31, 2024 · 0 comments

Comments

@HonzaR
Copy link
Collaborator

HonzaR commented May 31, 2024

Is your feature request related to a problem? Please describe.

We'd like to check and rethink the SDK exception system we have built-in. For example, RuntimeException from the Rust layer of the SDK should always be translated and enriched on the Kotlin side to a more detailed particular exception instead of throwing the RuntimeException itself.

Describe the solution you'd like

  • Translate all the RuntimeExceptions from the Rust layer
  • Check if all the exceptions from SdkException are used; remove the unused ones
  • Check if we catch and handle all RuntimeException from the Rust layer as necessary

Alternatives you've considered

Additional context

This will impact the SDK's public API, so make sure you update the Changelog as necessary

HonzaR added a commit that referenced this issue May 31, 2024
HonzaR added a commit that referenced this issue May 31, 2024
HonzaR added a commit that referenced this issue May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant