Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to use alternative sources of Checkpoint (TreeState) #1314

Open
pacu opened this issue Oct 30, 2023 · 0 comments · May be fixed by #1331
Open

Provide a way to use alternative sources of Checkpoint (TreeState) #1314

pacu opened this issue Oct 30, 2023 · 0 comments · May be fixed by #1331

Comments

@pacu
Copy link
Contributor

pacu commented Oct 30, 2023 •
edited

Is your feature request related to a problem? Please describe.

Provide a way for the SDK to use a different source of Checkpoint (TreeState) so that developers can use the SDK in different environments like REGTEST or Testnet-in-a-box

Initially, until a further analysis is conducted, this should be a development and testing feature, and should not be accessible through public APIs

Describe the solution you'd like

Decouple Checkpoint provision from the bundled Checkpoint in the SDK resources, so that other sources can be provided and implemented.

Alternatives you've considered

Removing bundled Checkpoints altogether (but it would require a major refactor all along the way from the mobile SDKs to the FFI layer and librustzcash.

Additional context

This has been identified as something that is needed for Adding Regtest support #1233
@pacu pacu mentioned this issue Oct 30, 2023
Closed
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Oct 31, 2023
@pacu
[Electric-Coin-Company#1314] Provide a way to use alternative sources…
39f4147 
… of Checkpoint (TreeState)

Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
@pacu pacu mentioned this issue Oct 31, 2023
Closed
14 tasks
@pacu pacu mentioned this issue Nov 28, 2023
Closed
@pacu pacu mentioned this issue Dec 12, 2023
Open
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Dec 12, 2023
@pacu
[Electric-Coin-Company#1330] Ability to provide custom checkpoints on…
9f1495f 
… Testing environments

Closes Electric-Coin-Company#1330
Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Dec 12, 2023
@pacu
[Electric-Coin-Company#1330] Ability to provide custom checkpoints on…
3f0d016 
… Testing environments

Closes Electric-Coin-Company#1330
Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
@pacu pacu linked a pull request Dec 12, 2023 that will close this issue
Open
14 tasks
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Dec 12, 2023
@pacu
[Electric-Coin-Company#1330] Ability to provide custom checkpoints on…
35c17ba 
… Testing environments

Closes Electric-Coin-Company#1330
Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Feb 6, 2024
@pacu
[Electric-Coin-Company#1330] Ability to provide custom checkpoints on…
f39c9e1 
… Testing environments

Closes Electric-Coin-Company#1330
Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Feb 20, 2024
@pacu
[Electric-Coin-Company#1330] Ability to provide custom checkpoints on…
7055ffe 
… Testing environments

Closes Electric-Coin-Company#1330
Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Feb 20, 2024
@pacu
[Electric-Coin-Company#1314] Provide a way to use alternative sources…
c469ae4 
… of Checkpoint (TreeState)

Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
pacu added a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Mar 14, 2024
@pacu
[Electric-Coin-Company#1330] Ability to provide custom checkpoints on…
09d2205 
… Testing environments

Closes Electric-Coin-Company#1330
Closes Electric-Coin-Company#1314

This implements a CheckpointSource that returns the checkpoint for height 663150
used on darksidewalletd tests.

also makes CheckpointSourceFactory an Enum so it can be initialized as
value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@pacu