This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
seo bundle #1
Merged
seo bundle #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->with('form.group_general') | ||
| ->add('name', 'text') | ||
| ->add('title', 'text') | ||
| ->add('body', 'textarea', array('required' => false)) |
There was a problem hiding this comment.
i really like wouters idea to move those to form types (that can live in the CmfSeoBundle and so on) and make the admin use those form types.
There was a problem hiding this comment.
Ahh ok. Sounds valid. Got his mail after that :-) will do it.
There was a problem hiding this comment.
@dbu i just realized, that the point you are pointing to is a test admin, which doesn't have any purpose on SeoBundle. SeoBundle itself has its own form type SeoMetadataType which still is in the SeoBundle.
There was a problem hiding this comment.
ups, sorry.
why do we need a test admin in the bundle that provides admins? to test
the extension? i guess that makes sense then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first one and moves the Admin stuf of CmfSeoBundle into that. For doing that the complete bundle structure needed to be created.