New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with turkish locale. #400

Closed
jikuja opened this Issue Feb 21, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jikuja

jikuja commented Feb 21, 2016

http://pastebin.com/emwEkAeZ

java.lang.IllegalArgumentException: No enum constant mods.eln.sixnode.electricalwatch.ElectricalWatchDescriptor.Kind.DİGİTAL
    at java.lang.Enum.valueOf(Unknown Source) ~[?:1.8.0_73]
    at mods.eln.sixnode.electricalwatch.ElectricalWatchDescriptor$Kind.valueOf(ElectricalWatchDescriptor.java:21) ~[ElectricalWatchDescriptor$Kind.class:?]
    at mods.eln.sixnode.electricalwatch.ElectricalWatchDescriptor.<init>(ElectricalWatchDescriptor.java:31) ~[ElectricalWatchDescriptor.class:?]
    at mods.eln.Eln.registerSixNodeMisc(Eln.java:1932) ~[Eln.class:?]
    at mods.eln.Eln.preInit(Eln.java:598) ~[Eln.class:?]

Probably caused by bad String.toUpperCase usage. Note: This method is locale sensitive, and may produce unexpected results if used for strings that are intended to be interpreted locale independently. Examples are programming language identifiers, protocol keys, and HTML tags. For instance, "title".toUpperCase() in a Turkish locale returns "T\u0130TLE", where '\u0130' is the LATIN CAPITAL LETTER I WITH DOT ABOVE character. To obtain correct results for locale insensitive strings, use toUpperCase(Locale.ENGLISH).

@cm0x4D

This comment has been minimized.

Member

cm0x4D commented Feb 21, 2016

Thanks for the issue, we may have a lot of trouble with toLowerCase() as well...

@cm0x4D cm0x4D closed this in 08d3f0b Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment