Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project to ensure all targets build and test #18

Merged
merged 4 commits into from
Dec 9, 2016
Merged

Update Project to ensure all targets build and test #18

merged 4 commits into from
Dec 9, 2016

Conversation

regnerjr
Copy link
Member

@regnerjr regnerjr commented Dec 8, 2016

The commit log should be pretty clear.

I was first alerted to the possibility of an issue when trying to checkout this module with carthage to try to update ELAnalytics which depends on it.

The output was:

 ✘  ~/dev/ELJSBridge   master ●  carthage update --no-use-binaries
*** Fetching ELLog
*** Fetching ELFoundation
*** Checking out ELFoundation at "v2.0.0"
*** Checking out ELLog at "v3.0.0"
*** xcodebuild output can be found in /var/folders/06/tf7sh6w14wn09ngqwp65lf9h0v9rz6/T/carthage-xcodebuild.PkUlMp.log
*** Building scheme "ELFoundation_osx" in ELFoundation.xcodeproj
** CLEAN FAILED **


The following build commands failed:
        Check dependencies
(1 failure)
** BUILD FAILED **


The following build commands failed:
        Check dependencies
(1 failure)
warning: no umbrella header found for target 'ELFoundation_osx', module map will not be generated
warning: no umbrella header found for target 'ELFoundation_osx', module map will not be generated
A shell task (/usr/bin/xcrun xcodebuild -project /Users/vn00ujn/dev/ELJSBridge/Carthage/Checkouts/ELFoundation/ELFoundation.xcodeproj -scheme ELFoundation_osx -configuration Release ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** CLEAN FAILED **


The following build commands failed:
        Check dependencies
(1 failure)
** BUILD FAILED **


The following build commands failed:
        Check dependencies
(1 failure)

There were a small number of changes required.

  1. Legacy Swift version was not specified. (As we probably will not go back to swift 2.3, I've set this at the project level to NO to track the latest swift version. (this should fix the above problem)
  2. Added The macOS Test target, to the macOS build target.
    buildtests
    And the Tests for macOS Should be configured to run under the macOS Scheme.
    runtests
  3. And finally there were files that were not found in the compile step for the macOS Tests target. I re-added them.
    missingfiles

Something needs to be specified here, either yes or no. With out this
the targets will fail to build.
The macOS scheme was not configured to include the test target as part
of its build steps. Also the test bundle was not configure to run when
testing.
@regnerjr
Copy link
Member Author

regnerjr commented Dec 8, 2016

Looks like some of my changes are the same as in #17 Let me know if I need to re-integrate or rebase my changes here. (also not sure why #17 is trying to use swift 2.3. I'm thinking some of the changes there are a bit old.)

@regnerjr
Copy link
Member Author

regnerjr commented Dec 9, 2016

Looks like the object association test is failing.

Test Suite 'All tests' failed at 2016-12-09 00:02:51.223.
	 Executed 17 tests, with 1 failure (0 unexpected) in 0.202 (0.319) seconds
Failing tests:
	-[ELFoundationTests testObjectAssociation()]

I saw this fail a few times in my own testing I can't seems to reliably reproduce it. (I initially thought that the cast on the object retrieval line should be as String instead of as String! but that does not seem to reliable fix it either. I've also seen this test fail under the mac_os_x Test suite too. So it should not be anything platform dependent. I'd look into this more but... ObjC runtime hackery is not really my specialty.
Let me know if I can help any more.

@angelodipaolo
Copy link
Contributor

Looks like #17 had branched off of the v1.1.x branch which has diverged from master to maintain a version compatible with Swift 2.3 . No need for you to rebase or re-integrate since since I updated #17 to base off of v1.1.x and merged it.

The testObjectAssociation test has been failing for awhile. I believe it started after migrating to Xcode 8/iOS 10. I can't reproduce it consistently and I believe the test passes when run on my local machine but seems to fail on Travis CI.

I'll go ahead and merge since this test has already been failing and none of your changes are related to it. I also opened issue #19 to track the broken test so we can address it later.

@angelodipaolo angelodipaolo merged commit 5d4d36f into Electrode-iOS:master Dec 9, 2016
@regnerjr regnerjr mentioned this pull request Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants