Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Swift 3 compatibility #5

Closed
wants to merge 1 commit into from
Closed

Update for Swift 3 compatibility #5

wants to merge 1 commit into from

Conversation

regnerjr
Copy link
Member

I see reference in the project file to an example project?
Should this be updated too?

Let me know if I can help of clean up anything further.

Hope this helps.

@angelodipaolo
Copy link
Contributor

Thanks for taking the time to update this for Swift 3! It would be great if you could also update the example project.

Since the Swift 3 changes are breaking API changes and will require a major version bump, I'd like to take this opportunity to improve the API and make other breaking changes. Mainly, replacing NetworkStatusInterpreter with an enum. Because of this, I'd like to wait to merge your Swift 3 updates into master until after the API changes are in so I can tag a stable 2.0.0 release. Could you please open a new PR with the new swift3 branch I just pushed up as the base instead of master?

Also, if you have any interest in taking on #4 feel free to make the changes as part of your PR.

@angelodipaolo angelodipaolo added this to the v2.0.0 milestone Oct 12, 2016
@regnerjr
Copy link
Member Author

Thanks for the encouragement @angelodipaolo I'll try to get to these changes over the next few days. I'll open an new pr to the new branch, and look at making the updates outlined in #4.

@angelodipaolo
Copy link
Contributor

@regnerjr no need to worry about making the changes in #4 now that @nonsensery fixed it with a slightly different in approach.

@regnerjr
Copy link
Member Author

Having some trouble getting some of the symbols to export correctly across the swift objc boundary.
Will try again later when I have some more time. Thanks.

@regnerjr regnerjr closed this Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants