Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements #219

Closed
2 of 4 tasks
Electroid opened this issue Jan 10, 2020 · 1 comment
Closed
2 of 4 tasks

Performance improvements #219

Electroid opened this issue Jan 10, 2020 · 1 comment
Labels
refactor Code needs to be redesigned

Comments

@Electroid
Copy link
Member

Electroid commented Jan 10, 2020 •
edited by Pablete1234
Loading

While refactoring in #218 I've noticed several things that will likely make PGM more performant.

  • We are copying Collections too much (ImmutableX)
  • Consider using fastutil.di.unimi.it
  • MatchModules need to be cleaned up on #unload(), most are not right now
  • Async sidebar (possible) and tablist (maybe possible)
@Electroid Electroid added the refactor Code needs to be redesigned label Jan 10, 2020
@Electroid Electroid self-assigned this Jan 10, 2020
@Electroid Electroid removed their assignment Jan 30, 2020
@Pablete1234
Copy link
Member

Pretty sure these are not relevant anymore, given how much time i've spent profiling performance issues on pgm, the remaining 2 listed are never showing up as relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code needs to be redesigned
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Electroid @Pablete1234