Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community edition #326

Closed
Electroid opened this issue Feb 17, 2020 · 0 comments · Fixed by #431
Closed

Community edition #326

Electroid opened this issue Feb 17, 2020 · 0 comments · Fixed by #431
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@Electroid
Copy link
Member

Electroid commented Feb 17, 2020

Figuring out what belongs in PGM and what doesn't is a tricky balancing act, and it's been difficult in the past. On one had, PGM works great "out-of-the-box" with features such as /a or settings. On the other hand, recent proposals and issues for #300, #305, #317, #280 highlight that putting them all in one package might be problematic in the future.

For developers:
I've already started breaking up PGM into "maven modules" such as api, core, util, and now I am considering adding a new module, community, which is essentially a "catch-all" for things that are useful for "scrimmage servers" but do not need to be in core.

Existing features like /report would be moved to community and recently rejected proposals for /punish, /freeze, and other moderation tools would be allowed back under community.

The community module would be slightly special, because it optionally depends on PGM. You can run the Community plugin without PGM, say on a map development server, but if PGM is present, then extra functionality that requires Match access would also be present. This module could also depend on util so we don't have to reinvent the wheel with translations and other things.

For users:
Commands like /report, /punish, /freeze and other continue to have support and default functionality in PGM. Commands like /vanish would be reconsidered under the new community scheme.

For server owners:
The PGM jar has the community module included by default, with an optional config option to remove it. The community jar would also be available for a separate download, for other use cases such as map development servers.

User and developer feedback is important, as well as compromise for a project like this one. It may take some time to get the module separation onto master, so I would be willing to fast-track some of the rejected moderation PRs and refactor them out later. Comments and feedback would be great!

cc @applenick @Pablete1234 @Brottweiler @KingOfSquares @AustinLMayes

@Electroid Electroid added feature New feature or request help wanted Extra attention is needed labels Feb 17, 2020
@Electroid Electroid self-assigned this Feb 17, 2020
@Electroid Electroid pinned this issue Feb 18, 2020
@Electroid Electroid linked a pull request Feb 22, 2020 that will close this issue
@Electroid Electroid removed a link to a pull request Feb 22, 2020
@Electroid Electroid added this to the API Release milestone Feb 27, 2020
@Electroid Electroid removed their assignment Feb 27, 2020
@Electroid Electroid changed the title RFC: Community edition Community edition Feb 27, 2020
This was referenced Apr 22, 2020
@Electroid Electroid linked a pull request May 2, 2020 that will close this issue
@Electroid Electroid unpinned this issue May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

1 participant