Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add Support for profiles #30

Open
Armaldio opened this issue Aug 30, 2019 · 0 comments
Open

[Proposal] Add Support for profiles #30

Armaldio opened this issue Aug 30, 2019 · 0 comments
Assignees
Projects

Comments

@Armaldio
Copy link
Member

Armaldio commented Aug 30, 2019

The command line could support profiles config files

This could work as follow:

config.js
config.dev.js
config.prod.js
config.custom.js

config.js

module.exports = {
	"electron": "6.0.1",
	...
}

config.dev.js

module.exports = {
	"electron": "6.0.1",
	"window": {	
	    "fullscreen": false, // no fullscreen on dev
	},
	...
}

config.prod.js

module.exports = {
	"electron": "6.0.1",
	"developer": {
    	"showConstructDevTools": false, // no devtools on prod
	},
	"window": {	
	    "fullscreen": true, // fullscreen on prod
	},
	...
}

config.custom.js

module.exports = {
	"electron": "5.0.0", // custom electron version
	...
}

Then you can specify profile on command:

$ efc build -p custom

That will merge config.js with config.custom.js

$ efc build -p dev

That will merge config.js with config.dev.js

@Armaldio Armaldio self-assigned this Aug 30, 2019
@Armaldio Armaldio added this to In progress in Release Sep 4, 2019
Armaldio added a commit that referenced this issue Sep 4, 2019
@Armaldio Armaldio moved this from In progress to Done in Release Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release
  
Done
Development

No branches or pull requests

1 participant