Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8.0 #846

Merged
merged 7 commits into from
Apr 27, 2024
Merged

Conversation

Lemon73-Computing
Copy link
Contributor

No description provided.

@FlorianRappl
Copy link
Collaborator

Quick question: What does work by having this changed? Right now you can use Electron.NET with .NET 6 onwards; this change would make it only compatible to .NET 8 onwards. I don't see any .NET 8 API being used, so I wonder - is that really necessary?

@Lemon73-Computing
Copy link
Contributor Author

Lemon73-Computing commented Apr 25, 2024

Now, electronize only runs on .net 6. However .net 6 is close to EoS. We can use electronize on new version (.net 8) project by my changed.

(Relate issue: #837)

@FlorianRappl
Copy link
Collaborator

Now, electronize only runs on .net 6. However .net 6 is close to EoS. We can use electronize on new version (.net 8) project by my changed.

(Relate issue: #837)

Yeah I agree the CLI should work on more targets. Potentially making the CLI independent of .NET (i.e., self-contained) would just solve this. This way we could go for .NET 8, but as its deployed as a self-contained CLI it would also work on any (older - or more recent) platform - escaping the need to install a fixed version of .NET.

I would say let's merge this and let's improve the CLI in the future.

self-contained
@Lemon73-Computing
Copy link
Contributor Author

Added:

<PublishSelfContained>true</PublishSelfContained>

@FlorianRappl FlorianRappl merged commit 21c17dc into ElectronNET:main Apr 27, 2024
2 of 3 checks passed
@Lemon73-Computing Lemon73-Computing deleted the net8.0 branch April 28, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants