New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execv error codes #1590

Open
markus2330 opened this Issue Aug 26, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@markus2330
Contributor

markus2330 commented Aug 26, 2017

Seems like we checked the error codes of execv wrong in 3 out of 4 places:

  • src/plugins/shell/shell.c:32: return execv ("/bin/sh", cmd)
  • src/plugins/crypto/gpg.c:802: if (execv (argv[0], argv) < 0) ... return -1
  • src/tools/kdb/external.cpp:183: (no check)

We should either communicate failed execv by the exit status (as done in src/tools/kdb/external.cpp:196) or by pipes (then we could communicate the errno or even strings).

@tom-wa Can you fix the shell plugin please?
@petermax2 Can you fix the crypto plugin please?

@markus2330 markus2330 referenced this issue Aug 26, 2017

Merged

Fix compiler warnings (#1579 ) #1589

2 of 6 tasks complete

petermax2 added a commit to petermax2/libelektra that referenced this issue Aug 27, 2017

BernhardDenner added a commit to BernhardDenner/libelektra that referenced this issue Oct 14, 2017

BernhardDenner added a commit to BernhardDenner/libelektra that referenced this issue Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment