New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: build all job #1711

Closed
markus2330 opened this Issue Nov 30, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@markus2330
Contributor

markus2330 commented Nov 30, 2017

As proposed by @sanssecours we could add the "jenkins build all please" phrase to every build job.

This way we could avoid merging PRs that break some build job.

Maybe we should exclude the build jobs that are already triggered immediately anyway?
Any suggestions for a better name than "jenkins build all please"?

(see also #160)

@markus2330 markus2330 added the proposal label Nov 30, 2017

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Dec 10, 2017

Contributor

Maybe we should exclude the build jobs that are already triggered immediately anyway?

Makes sense.

Any suggestions for a better name than "jenkins build all please"?

Nope. The phrase sounds good to me.

Contributor

sanssecours commented Dec 10, 2017

Maybe we should exclude the build jobs that are already triggered immediately anyway?

Makes sense.

Any suggestions for a better name than "jenkins build all please"?

Nope. The phrase sounds good to me.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Dec 10, 2017

Contributor

If we also want to exclude the build jobs that were executed by default, we might better have two phrases:

  • "jenkins build all please"
  • "jenkins build others please"

("build all" is still relevant if master is changed because this wont trigger the default build jobs for the PRs)

Contributor

markus2330 commented Dec 10, 2017

If we also want to exclude the build jobs that were executed by default, we might better have two phrases:

  • "jenkins build all please"
  • "jenkins build others please"

("build all" is still relevant if master is changed because this wont trigger the default build jobs for the PRs)

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Dec 10, 2017

Contributor

If we also want to exclude the build jobs that were executed by default, we might better have two phrases…

You are right. In that case I am for including the PR build jobs too. The simplification (only one special build phrase) should make up for the overhead of building the PR jobs twice.

Contributor

sanssecours commented Dec 10, 2017

If we also want to exclude the build jobs that were executed by default, we might better have two phrases…

You are right. In that case I am for including the PR build jobs too. The simplification (only one special build phrase) should make up for the overhead of building the PR jobs twice.

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Dec 11, 2017

Contributor

I just added the new build phrase to the triggers of almost all jobs. I did not incorporate the phrase in the build jobs

  • elektra-git-buildpackage-jessie,
  • elektra-git-buildpackage-stretch, and
  • elektra-git-buildpackage-wheezy

, since I am not sure that building the packages makes much sense in the case of a pull request. I also did not attach the phrase to

  • PR-checks, and
  • elektra-todo

. Do you think we should add some of the build jobs above to jenkins build all please too?

Contributor

sanssecours commented Dec 11, 2017

I just added the new build phrase to the triggers of almost all jobs. I did not incorporate the phrase in the build jobs

  • elektra-git-buildpackage-jessie,
  • elektra-git-buildpackage-stretch, and
  • elektra-git-buildpackage-wheezy

, since I am not sure that building the packages makes much sense in the case of a pull request. I also did not attach the phrase to

  • PR-checks, and
  • elektra-todo

. Do you think we should add some of the build jobs above to jenkins build all please too?

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Dec 11, 2017

Contributor

Thank you so much, its great to have jenkins build all please available. Can you document it in doc/GIT.md (if not done so already)?

Yes, the buildpackage jobs do not work for PRs.

I do not know what PR-checks is for, afaik it was created by @BernhardDenner

The elektra-todo is not really relevant (currently it is not used at all) but it also does not harm to add it? (One exception less.)

Contributor

markus2330 commented Dec 11, 2017

Thank you so much, its great to have jenkins build all please available. Can you document it in doc/GIT.md (if not done so already)?

Yes, the buildpackage jobs do not work for PRs.

I do not know what PR-checks is for, afaik it was created by @BernhardDenner

The elektra-todo is not really relevant (currently it is not used at all) but it also does not harm to add it? (One exception less.)

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Dec 11, 2017

Contributor

Thank you so much, its great to have jenkins build all please available. Can you document it in doc/GIT.md (if not done so already)?

I am already working on it.

I do not know what PR-checks is for, afaik it was created by @BernhardDenner

The elektra-todo is not really relevant (currently it is not used at all) but it also does not harm to add it? (One exception less.)

Okay. I just added the phrase to both jobs.

Contributor

sanssecours commented Dec 11, 2017

Thank you so much, its great to have jenkins build all please available. Can you document it in doc/GIT.md (if not done so already)?

I am already working on it.

I do not know what PR-checks is for, afaik it was created by @BernhardDenner

The elektra-todo is not really relevant (currently it is not used at all) but it also does not harm to add it? (One exception less.)

Okay. I just added the phrase to both jobs.

sanssecours added a commit to sanssecours/elektra that referenced this issue Dec 11, 2017

Jenkins: Add information about phrase for all jobs
We now can use the phrase

    jenkins build all please

to build (almost) all Jenkins jobs.

This commit closes ElektraInitiative#1711.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment