Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellrecorder: fail if writing outside of /tests #1887

Closed
2 tasks
Tracked by #4482
markus2330 opened this issue Apr 4, 2018 · 7 comments
Closed
2 tasks
Tracked by #4482

shellrecorder: fail if writing outside of /tests #1887

markus2330 opened this issue Apr 4, 2018 · 7 comments
Labels
enhancement stale testing errors in tests without implication on real usage
Projects
1.0

Comments

@markus2330
Copy link
Contributor

markus2330 commented Apr 4, 2018 •
edited
Loading

Although TESTING.md clearly defines that only /tests/<testname> is allowed for writing, quite some tutorials, plugins, tests do differently. Following Elektra paths seem to be used:
@markus2330 markus2330 added the bug label Apr 4, 2018
@markus2330 markus2330 mentioned this issue Apr 4, 2018
Closed
@markus2330
Copy link
Contributor Author

As discussed, only /tests is allowed.

@markus2330 markus2330 mentioned this issue May 12, 2018
Closed
@sanssecours sanssecours mentioned this issue May 14, 2018
Merged
7 tasks
sanssecours added a commit to sanssecours/elektra that referenced this issue May 14, 2018
@sanssecours
Template: Save test data below /tests
8c3df2d 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 14, 2018
@sanssecours
Template: Save test data below /tests
65fc6af 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 17, 2018
@sanssecours
Template: Save test data below /tests
f6ccf1f 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 17, 2018
@sanssecours
Template: Save test data below /tests
561cd68 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 18, 2018
@sanssecours
Template: Save test data below /tests
2b405ae 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 18, 2018
@sanssecours
Template: Save test data below /tests
0fab9e5 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 19, 2018
@sanssecours
Template: Save test data below /tests
188a973 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 19, 2018
@sanssecours
Template: Save test data below /tests
0156024 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 19, 2018
@sanssecours
Template: Save test data below /tests
ab54558 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 19, 2018
@sanssecours
Template: Save test data below /tests
2e33aec 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 20, 2018
@sanssecours
Template: Save test data below /tests
0562ee7 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 20, 2018
@sanssecours
Template: Save test data below /tests
891528b 
This update addresses issue ElektraInitiative#1887.
@sanssecours sanssecours mentioned this issue May 20, 2018
Merged
4 tasks
sanssecours added a commit to sanssecours/elektra that referenced this issue May 21, 2018
@sanssecours
MSR: Check if kdb sets data outside of /tests
3076962 
While this update will **not** catch every occurrence of test code that
saves data outside of `/tests`, it should handle most cases without
adding to much overhead.

This commit addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 23, 2018
@sanssecours
Template: Save test data below /tests
e92f511 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 23, 2018
@sanssecours
MSR: Check if kdb sets data outside of /tests
b08fbbf 
While this update will **not** catch every occurrence of test code that
saves data outside of `/tests`, it should handle most cases without
adding to much overhead.

This commit addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 23, 2018
@sanssecours
Template: Save test data below /tests
8ee52c7 
This update addresses issue ElektraInitiative#1887.
sanssecours added a commit to sanssecours/elektra that referenced this issue May 23, 2018
@sanssecours
MSR: Check if kdb sets data outside of /tests
bfc4234 
While this update will **not** catch every occurrence of test code that
saves data outside of `/tests`, it should handle most cases without
adding to much overhead.

This commit addresses issue ElektraInitiative#1887.
@markus2330
Copy link
Contributor Author

The next step would be to let the shell recorder fail if data outside of /tests is accessed.

@markus2330 markus2330 changed the title Unify which Elektra paths are used for tutorials tests shellrecorder: fail if writing outside of /tests Feb 17, 2019
@markus2330 markus2330 added the testing errors in tests without implication on real usage label Apr 12, 2020
@stale
Copy link

stale bot commented Apr 15, 2021

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@stale stale bot added the stale label Apr 15, 2021
@stale
Copy link

stale bot commented Apr 30, 2021

I closed this issue now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@stale stale bot closed this as completed Apr 30, 2021
@mpranj mpranj added this to the 1.0.0 milestone Apr 30, 2021
@mpranj mpranj added this to Cleanup in 1.0 Apr 30, 2021
@mpranj mpranj reopened this Apr 30, 2021
@stale stale bot removed the stale label Apr 30, 2021
@markus2330 markus2330 mentioned this issue May 2, 2021
Closed
@markus2330 markus2330 modified the milestones: 1.0.0, 0.9.* May 2, 2021
@stale
Copy link

stale bot commented May 2, 2022

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@stale stale bot added the stale label May 2, 2022
@markus2330 markus2330 removed the stale label May 3, 2022
@markus2330 markus2330 mentioned this issue Sep 25, 2022
Closed
4 tasks
@markus2330 markus2330 removed this from the 0.9.* milestone Nov 18, 2022
@github-actions GitHub Actions
Copy link

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot added the stale label Feb 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
1.0 automation moved this from Cleanup to Done Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement stale testing errors in tests without implication on real usage
Projects
1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpranj @markus2330