New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLOSS] Toml plugin fails silently on meta-set #4579
Comments
Bujuhu
changed the title
[Floss H1] Toml plugin fails silently on meta-set
[Floss] Toml plugin fails silently on meta-set
Oct 19, 2022
Bujuhu
changed the title
[Floss] Toml plugin fails silently on meta-set
[FLOSS] Toml plugin fails silently on meta-set
Oct 19, 2022
8 tasks
Bujuhu
added a commit
to Bujuhu/libelektra
that referenced
this issue
Nov 28, 2022
23 tasks
Bujuhu
added a commit
to Bujuhu/libelektra
that referenced
this issue
Nov 28, 2022
Bujuhu
added a commit
to Bujuhu/libelektra
that referenced
this issue
Nov 28, 2022
Bujuhu
added a commit
to Bujuhu/libelektra
that referenced
this issue
Nov 29, 2022
joni1993
pushed a commit
to joni1993/libelektra
that referenced
this issue
Dec 5, 2022
Dynamichost96
pushed a commit
to Dynamichost96/libelektra
that referenced
this issue
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in #4555, the toml storage plugin fails silently, when setting unknown meta keys
Steps to Reproduce the Problem
Expected Result
Should either print an error on
kdb meta-set user:/tests/storage/types blue blah
and return a non 0 exit code orkdb meta-get user:/tests/storage/types blue
should return blahActual Result
kdb meta-set user:/tests/storage/types blue blah
fails silently andkdb meta-get user:/tests/storage/types blue
returns an key not found errorSystem Information
Operating System:
Arch Linux, Kernel 5.19.13-arch1-1
kdb and plugins version
# kdb --version KDB_VERSION: 0.9.11 SO_VERSION: 5
Relevant Source Code
This happens because both the type and toml plugins only look for meta keys if they are of use for said plugins. If not, they are simply ignored.
libelektra/src/plugins/type/type.c
Line 372 in cf4b6f3
libelektra/src/plugins/type/type.c
Line 65 in cf4b6f3
libelektra/src/plugins/toml/prepare.c
Line 263 in cf4b6f3
libelektra/src/plugins/toml/prepare.c
Line 167 in cf4b6f3
The text was updated successfully, but these errors were encountered: