Tests: Various Minor Improvements #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus2330
reviewed
Feb 14, 2019
| # Mount yamlcpp plugin to cascading namespace `/tests/yamlcpp` | ||
| sudo kdb mount config.yaml /tests/yamlcpp yamlcpp | ||
| # Mount yamlcpp plugin to `user/tests/yamlcpp` | ||
| sudo kdb mount config.yaml user/tests/yamlcpp yamlcpp |
There was a problem hiding this comment.
Why to use user instead of cascading?
There was a problem hiding this comment.
I used the explicit namespace, since otherwise the output of the command kdb ls in line 86 would depend on the (root or non-root) user that executes the test.
There was a problem hiding this comment.
Thanks for the tip! Maybe we should write that somewhere in the shell recorder tutorial?
There was a problem hiding this comment.
I do not think that is necessary. The output of failing Markdown Shell Recorder tests on FreeBSD should already show the issue to someone who might not expect that behavior.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.