Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: semlock: enable it #2411

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@KurtMi
Copy link

KurtMi commented Feb 12, 2019

Basics

Do not describe the purpose here but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains *(my name)*)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins)
@markus2330

This comment has been minimized.

Copy link
Contributor

markus2330 commented Feb 14, 2019

Thank you for looking at it!

@KurtMi

This comment has been minimized.

Copy link
Author

KurtMi commented Feb 18, 2019

jenkins build all please

@markus2330

This comment has been minimized.

Copy link
Contributor

markus2330 commented Apr 2, 2019

What about removing the semlock plugin as it does not seem to be easy to add? Or should we wait until the global plugins are reworked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.