Plugins: semlock: remove it

[KurtMi]

Basics

Do not describe the purpose here but:

• Short descriptions should be in the release notes (added as entry in
  doc/news/_preparation_next_release.md which contains *(my name)*)
  Please always add something to the the release notes.
• Longer descriptions should be in documentation or in design decisions.
• Describe details of how you changed the code in commit messages
  (first line should have module: short statement syntax)
• References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

• I added unit tests
• I ran all tests locally and everything went fine
• affected documentation is fixed
• I added code comments, logging, and assertions (see doc/CODING.md)
• meta data is updated (e.g. README.md of plugins)

[markus2330]

Thank you for looking at it!

[KurtMi]

jenkins build all please

[markus2330]

What about removing the semlock plugin as it does not seem to be easy to add? Or should we wait until the global plugins are reworked?

[KurtMi]

@markus2330 I removed the semlock plugin

[markus2330]

Thank you for the PR! The problem with the Debian package should be fixed now.

[markus2330]

Was it because of the problems in hooks, because of OS-specific problems, or something else?

[KurtMi]

Manly OS-specifics /dev/shm should be mounted as tempfs for example. But I also see no reason for the semlock, the main reason was the race test, but the timestamp consistency check between KdbGet and KdnSet made the race test broken by design.

[markus2330]

Yes, you are right. The semlock plugin alone cannot fix the race tests.

[markus2330]

change to "implement semlock plugin"

[markus2330]

I also retriggered the mac build jobs.

[sanssecours]

Please rebase this PR on the master branch. Without the changes of commit 483752d the source code formatting checks on Cirrus CI will always fail otherwise.

[KurtMi]

jenkins build all please

[markus2330]

@KurtMi thank you very much! I hope we will see further contributions from you!