New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving issue #2541 #2735
Resolving issue #2541 #2735
Changes from 12 commits
e5b4fc0
5ff1e38
f5987c8
d7ae031
0d53d33
2922bf3
0c836bb
2450cf3
ee24cff
729a802
a20274f
e0c6653
fe45216
8bb9385
51c380f
1e9a797
d243342
95a8a21
aa1031c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -367,6 +367,14 @@ removed due to: | |
- New plugin to validate hex formatted colors (e.g. #fff or #abcd) and normalize them to rgba (4294967295 (= 0xffffffff) and 2864434397 (= 0xaabbccdd) respectively). It also has support for named colors according to the [extended color keywords](https://www.w3.org/TR/css-color-3/#svg-color) from CSS3. | ||
_(Philipp Gackstatter)_ | ||
|
||
### Ini | ||
|
||
- new formatting is introduced --> instead of having whitespaces around '=' now the whitespaces are not allowed anymore | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The whitespaces should be allowed (it would be an incompatible change to disallow it) but the INI plugin should not write out these whitespaces anymore. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @markus2330 Thank you for your comment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am sorry for the confusion but #2065 clearly says that something additional should be supported and it does not mention that previous working files should be rejected. I do not think you need to rewrite all tests, nor that your changes are useless. In all tests where the INI file is written you obviously need to remove the spaces, otherwise the files would not be identical after writing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @markus2330
after writing for example --
the result would be
Do you confirm this kind of behaviour is what it should be? @markus2330 Can you please reward my group colleague @e01306821 with some extra points for the class? He provided me support multiple times and deserves nothing less than a "1" in my opinion. Sorry for the off-topic. =) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes, perfect. This should fix #2541.
Yes. Please try to reflect what you learned in the tutorials/docu. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I will! Thank you very much! |
||
example of old formatting: key1 = value1 | ||
example of new formatting: key1=value1 | ||
|
||
. _(Oleksandr Shabelnyk)_ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please fix the indentation of your name (exactly two spaces before the dot). Otherwise your name will show up in code style: . If you want to know why that is the case, please take a look at the Markdown specification. |
||
|
||
## Libraries | ||
|
||
The text below summarizes updates to the [C (and C++)-based libraries](https://www.libelektra.org/libraries/readme) of Elektra. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -226,14 +226,14 @@ the human readable [ni format](/src/plugins/ni/README.md) by using `kdb import`) | |
sudo kdb mount tutorial.dump spec/tests/tutorial dump | ||
cat << HERE | kdb import spec/tests/tutorial ni \ | ||
[] \ | ||
mountpoint = tutorial.dump \ | ||
infos/plugins = dump validation \ | ||
mountpoint=tutorial.dump \ | ||
infos/plugins=dump validation \ | ||
\ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please also remove two whitespaces in line 231 and 232 to keep the formatting consistent. |
||
[/links/_] \ | ||
check/validation = https?://.*\..* \ | ||
check/validation/match = LINE \ | ||
check/validation/message = not a valid URL \ | ||
description = A link to some website \ | ||
check/validation=https?://.*\..* \ | ||
check/validation/match=LINE \ | ||
check/validation/message=not a valid URL \ | ||
description=A link to some website \ | ||
HERE | ||
kdb lsmeta spec/tests/tutorial | ||
#> infos/plugins | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
[section] | ||
key = outside start | ||
key=outside start | ||
### block config start | ||
[section] | ||
key = only the inside has changed | ||
key=only the inside has changed | ||
### block config stop | ||
[section] | ||
key = outside end | ||
key=outside end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
[section] | ||
key = outside start | ||
key=outside start | ||
### block config start | ||
[section] | ||
key = inside block | ||
key=inside block | ||
### block config stop | ||
[section] | ||
key = outside end | ||
key=outside end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
a = hell� | ||
a=hell� |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
"value = long | ||
"value=long | ||
key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use title-case for headers.