Covered Resolving Missing *.so Library Error #2777

oleksandr-shabelnyk · 2019-06-12T12:38:01Z

@markus2330 please review my PR

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

Short descriptions should be in the release notes (added as entry in
doc/news/_preparation_next_release.md which contains _(my name)_)
Please always add something to the the release notes.
Longer descriptions should be in documentation or in design decisions.
Describe details of how you changed the code in commit messages
(first line should have module: short statement syntax)
References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

I added unit tests
I ran all tests locally and everything went fine
affected documentation is fixed
I added code comments, logging, and assertions (see Coding Guidelines)
meta data is updated (e.g. README.md of plugins and METADATA.ini)

Review

Reviewers will usually check the following:

Code is conforming to our Coding Guidelines
APIs are conforming to our Design Guidelines
Code is consistent to our Design Decisions
Documentation is concise and good to read
Examples are well chosen and understandable

Labels

Add the "work in progress" label if you do not want the PR to be reviewed yet.
Add the "ready to merge" label if the build server is happy and also you
say that everything is ready to be merged.

merge

oleksandr-shabelnyk · 2019-06-12T17:26:56Z

The Travis CI build was timed out, although the tests seem to be OK. Any idea why?

markus2330

Thank you! Some content is a bit misplaced.

markus2330 · 2019-06-12T18:36:40Z

doc/COMPILE.md

@@ -712,6 +712,32 @@ For reference, you can look into the
 and the
 [CMake in OpenWRT](https://github.com/openwrt/openwrt/blob/master/include/cmake.mk).

+### Resolving Missing \*.so Library Error


What you write here is only about run-time problems, it is unrelated to compiling (and the recommended solution of how to deal with .so is already in this document a bit above (about RPATH).

Maybe best if you put a condensed version of this directly to contributing-clion.md because it is not enough for its own tutorial and I would actually not recommend to do it this way, except if the IDE does not support to run scripts/run_dev_env

Well, you said it yourself I should put in into compile.md. Sure, it makes more sense to have in contributing-clion.md.

Sorry, for the confusion. I pointed you to COMPILE.md because there is already a description of the solution to your problem. The "library" not found is a topic that spreads from compiling, installing to run-time. Your solution is run-time only, though.

markus2330 · 2019-06-12T18:37:00Z

doc/COMPILE.md

+Run this script to set environmental variables for development purpose:
+
+```sh
+. /home/osboxes/TU/libelektra/scripts/run_dev_env


This is specific to your config, it will not help someone else.

Ok, I will remove it.

When you write: "Let us assume that the source dir is in..., then..." it would be okay.

sanssecours · 2019-06-13T08:47:04Z

The Travis CI build was timed out, although the tests seem to be OK. Any idea why?

Unfortunately the hardware Travis uses for macOS builds is quite slow. Since Travis has a timeout limit of 50 minutes for public repositories, this means sometimes a build job will fail, just because of this limitation 😢. The usual quick, but certainly no ideal fix for that problem, is to just rerun the build job that hit the timeout limit.

alexsaber · 2019-06-13T08:49:45Z

@markus2330 you requested changes but did not say which ones. Can you please list them?

markus2330

Thank you, nearly finished.

markus2330 · 2019-06-13T09:37:08Z

doc/news/_preparation_next_release.md

@@ -543,6 +543,7 @@ mounted, use `kdb gen -F <plugin>:<file> elektra <parentKey> <outputName>` to lo
 - Added a section on `elektraPluginGetGlobalKeySet` in the plugin tutorial. _(Vid Leskovar)_
 - Added a step-by-step [tutorial](../tutorials/run_all_tests_with_docker.md) for running all tests with Docker. _(Oleksandr Shabelnyk)_
 - Added a step-by-step [tutorial](../tutorials/run_reformatting_script_with_docker.md) for running reformatting scripts with Docker. _(Oleksandr Shabelnyk)_
+- Covered Resolving Missing \*.so Library Error in [tutorial](../tutorials/contributing-clion.md) and [tutorial](../COMPILE.md). _(Oleksandr Shabelnyk)_


Outdated information (COMPILE.md is not modified).

Thank you. I forgot to remove it.

markus2330 · 2019-06-13T09:37:50Z

doc/tutorials/contributing-clion.md

+LD_LIBRARY_PATH="/path/you/want1:/path/you/want/2"
+```
+
+Please keep in mind it sets the variable only in the currently opened shell window/session. To make it persistent please search online how to do it for you Linux distribution.


Here you can refer to COMPILE.md (it contains instructions of how to fix the problem permanently.)

markus2330 · 2019-06-13T09:39:30Z

doc/tutorials/contributing-clion.md

+If you want to run built `kdb` outside of CLion, you can set the LD_LIBRARY_PATH variable like this in command line:
+
+```sh
+LD_LIBRARY_PATH="/path/you/want1:/path/you/want/2"


Outside of CLion, please only recommend the script scripts/run_dev_env. The only reason to make it differently in CLion is that CLion currently does not support executing scripts for the environment. (Please also write that).

markus2330 · 2019-06-13T09:40:38Z

@markus2330 you requested changes but did not say which ones. Can you please list them?

I do not understand the question. I wrote two reviews and in the review comments it says what should be changed.

alexsaber · 2019-06-13T20:40:03Z

@markus2330 you requested changes but did not say which ones. Can you please list them?

I do not understand the question. I wrote two reviews and in the review comments it says what should be changed.

When I left this comment I did not see your comments. I am sorry for the confusion.

markus2330

Still not correct.

markus2330 · 2019-06-14T12:00:58Z

doc/tutorials/contributing-clion.md

+If you want to run built `kdb` outside of CLion, the recommended way is to run this script:
+
+```sh
+./scripts/run_dev_env


You need to source this (. (space!) or source ), otherwise it does not work.

And you forgot to say that you need to be in the build dir.

See the example in the issue where you had this problem.

I am so sorry. I fixed it.

markus2330 · 2019-06-14T12:02:05Z

doc/tutorials/contributing-clion.md

+./scripts/run_dev_env
+```
+
+If it does not work, there is another way around, which you should use only as the last resort. Set the LD_LIBRARY_PATH variable like this in command line:


Please do not recommend this. It is better if you describe how to source a script with the . operator. (You can also add this to doc/TESTING.md).

I will remove it. I think it is better.

markus2330 · 2019-06-14T12:03:40Z

doc/tutorials/contributing-clion.md

+LD_LIBRARY_PATH="/path/you/want1:/path/you/want/2"
+```
+
+Please keep in mind it sets the variable only in the currently opened shell window/session.


This is also correct for the scripts/run_dev_env but:

Suggested change

Please keep in mind it sets the variable only in the currently opened shell window/session.

Please keep in mind it sets the variables only in the currently opened shell window/session.

alexsaber · 2019-06-14T16:01:36Z

@markus2330 thank you!
I changed everything. Is it good now?

markus2330 · 2019-06-14T19:53:28Z

doc/tutorials/contributing-clion.md

+If you want to run built `kdb` outside of CLion, the recommended way is to run this script from your build directory:
+
+```sh
+. /scripts/run_dev_env


Please try out what you write: here you assume scripts to be in root of the whole filesystem but it is in root of Elektra's source directory.

markus2330 · 2019-06-15T17:47:54Z

Thank you!

oleksandr-shabelnyk and others added 2 commits June 12, 2019 13:52

Merge pull request #1 from ElektraInitiative/master

2772384

merge

Cover Resolving Missing *.so Library error

994e18f

oleksandr-shabelnyk changed the title ~~Covered Resolving Missing \*.so Library Error~~ Covered Resolving Missing *.so Library Error Jun 12, 2019

Fix link

02ff700

alexsaber mentioned this pull request Jun 12, 2019

CLion: running kdb in debug mode #2766

Closed

markus2330 requested changes Jun 12, 2019

View reviewed changes

Move the whole instruction to contributing-clion.md only

f5dc841

markus2330 requested changes Jun 13, 2019

View reviewed changes

changes

2a38705

sanssecours added cm2019s enhancement usability labels Jun 14, 2019

markus2330 requested changes Jun 14, 2019

View reviewed changes

further changes

9c4ffe6

markus2330 reviewed Jun 14, 2019

View reviewed changes

fix path to rn_dev_env script

0ec5460

markus2330 approved these changes Jun 15, 2019

View reviewed changes

markus2330 merged commit e42f23c into ElektraInitiative:master Jun 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Covered Resolving Missing *.so Library Error #2777

Covered Resolving Missing *.so Library Error #2777

oleksandr-shabelnyk commented Jun 12, 2019

oleksandr-shabelnyk commented Jun 12, 2019

markus2330 left a comment

markus2330 Jun 12, 2019

alexsaber Jun 12, 2019

markus2330 Jun 13, 2019

markus2330 Jun 12, 2019

alexsaber Jun 12, 2019

markus2330 Jun 13, 2019

sanssecours commented Jun 13, 2019

alexsaber commented Jun 13, 2019

markus2330 left a comment

markus2330 Jun 13, 2019

alexsaber Jun 13, 2019

markus2330 Jun 13, 2019

alexsaber Jun 13, 2019

markus2330 Jun 13, 2019

alexsaber Jun 13, 2019

markus2330 commented Jun 13, 2019

alexsaber commented Jun 13, 2019

markus2330 left a comment

markus2330 Jun 14, 2019

alexsaber Jun 14, 2019

markus2330 Jun 14, 2019

alexsaber Jun 14, 2019

markus2330 Jun 14, 2019

alexsaber Jun 14, 2019

alexsaber commented Jun 14, 2019

markus2330 Jun 14, 2019

alexsaber Jun 15, 2019

markus2330 commented Jun 15, 2019

	Please keep in mind it sets the variable only in the currently opened shell window/session.
	Please keep in mind it sets the variables only in the currently opened shell window/session.

Covered Resolving Missing *.so Library Error #2777

Covered Resolving Missing *.so Library Error #2777

Conversation

oleksandr-shabelnyk commented Jun 12, 2019

Basics

Checklist

Review

Labels

oleksandr-shabelnyk commented Jun 12, 2019

markus2330 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanssecours commented Jun 13, 2019

alexsaber commented Jun 13, 2019

markus2330 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markus2330 commented Jun 13, 2019

alexsaber commented Jun 13, 2019

markus2330 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexsaber commented Jun 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markus2330 commented Jun 15, 2019