New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make jni depend on jna to avoid mvn dependency resolution fails #3113
Conversation
@sanssecours do you think that this is the correct approach to avoid jna and jni be built in parallel? Or should I add its own dependency such as
You are very proficient in cmake as far as I can tell :) |
Adding an additional dependency seems to be the correct approach. However, I think we need to add the dependency earlier. For me it would make sense to require a compiled JNA binding, before we call Maven in the CMake code of the JNI plugin. I think adding libelektra/src/plugins/jni/CMakeLists.txt Line 74 in 8d138a2
should accomplish that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it solves the problem, it looks good to me.
jenkins build libelektra please |
Please do not restart too many build jobs at once. It seems like this was too much for the server, see #160. |
jenkins build libelektra please |
1 similar comment
jenkins build libelektra please |
Thank you! Hopefully this fixed #2855. |
Basics
These points need to be fulfilled for every PR:
(added as entry in
doc/news/_preparation_next_release.md
whichcontains
_(my name)_
)Please always add something to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.
Checklist
Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.
(not in the PR description)
Review
Reviewers will usually check the following:
Labels
If you are already Elektra developer:
say that everything is ready to be merged.