Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make jni depend on jna to avoid mvn dependency resolution fails #3113

Merged
merged 2 commits into from Oct 30, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2019

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy.
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

@ghost
Copy link
Author

ghost commented Oct 25, 2019

@sanssecours do you think that this is the correct approach to avoid jna and jni be built in parallel?

Or should I add its own dependency such as

add_dependencies (jni jna)

You are very proficient in cmake as far as I can tell :)

@sanssecours
Copy link
Member

@sanssecours do you think that this is the correct approach to avoid jna and jni be built in parallel?

Adding an additional dependency seems to be the correct approach. However, I think we need to add the dependency earlier. For me it would make sense to require a compiled JNA binding, before we call Maven in the CMake code of the JNI plugin. I think adding jna to the argument DEPENDS here:

DEPENDS "${LIBELEKTRA4J_PATH}/pom.xml")

should accomplish that.

@dominicjaeger dominicjaeger mentioned this pull request Oct 25, 2019
31 tasks
Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it solves the problem, it looks good to me.

@ghost
Copy link
Author

ghost commented Oct 28, 2019

jenkins build libelektra please

@markus2330
Copy link
Contributor

Please do not restart too many build jobs at once. It seems like this was too much for the server, see #160.

@ghost
Copy link
Author

ghost commented Oct 29, 2019

jenkins build libelektra please

1 similar comment
@ghost
Copy link
Author

ghost commented Oct 29, 2019

jenkins build libelektra please

@ghost ghost added the ready to merge label Oct 30, 2019
@markus2330 markus2330 merged commit 86527b2 into ElektraInitiative:master Oct 30, 2019
@markus2330
Copy link
Contributor

Thank you! Hopefully this fixed #2855.

@ghost ghost deleted the mvn_build_problem_fix branch October 30, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants