Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdb rewrite set #4954

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Kdb rewrite set #4954

merged 1 commit into from
Jun 1, 2023

Conversation

hannes99
Copy link
Contributor

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

Copy link
Member

@kodebach kodebach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one small oversight in the docs

doc/tutorials/cascading.md Outdated Show resolved Hide resolved
@hannes99 hannes99 force-pushed the kdb_rewrite_external branch 2 times, most recently from adbc30b to 499db7d Compare May 31, 2023 14:56
@hannes99 hannes99 changed the base branch from kdb_rewrite_external to kdb_rewrite_base May 31, 2023 15:08
... and (partial) fix #3742, fix #4028, fix #1164
@hannes99
Copy link
Contributor Author

hannes99 commented Jun 1, 2023

jenkins build libelektra please

1 similar comment
@hannes99
Copy link
Contributor Author

hannes99 commented Jun 1, 2023

jenkins build libelektra please

@hannes99 hannes99 merged commit 21193e3 into kdb_rewrite_base Jun 1, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants