Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Binding wrap up #4972

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Conversation

tucek
Copy link
Contributor

@tucek tucek commented Jul 2, 2023

  • Updated Java Binding documentation

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@tucek tucek self-assigned this Jul 2, 2023
@tucek tucek added this to In progress in Java bindings overhaul via automation Jul 2, 2023
@tucek tucek requested a review from markus2330 July 12, 2023 05:00
@tucek tucek marked this pull request as ready for review July 12, 2023 05:02
@markus2330 markus2330 merged commit 7433242 into ElektraInitiative:master Jul 14, 2023
14 of 17 checks passed
Java bindings overhaul automation moved this from In progress to Done Jul 14, 2023
@markus2330
Copy link
Contributor

Great job, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants