WIP: spec fix

[tom-wa]

crude hacked together code, just a possible approach

[tom-wa]

@markus2330 is this kind of approach to fix the problem with getting non-existing keys ok with you ?

[markus2330]

It seems like you try to solve an ordering issue in an unappropriate way.
Certainly not every plugin is fine with getting executed twice.
Why not add an additional hook as discussed?

[tom-wa]

couldn't fine any other way to do it.
the keyset needed for global plugins (spec) only exists after elektraGetDoUpdate, but the backends plugins are all executed within elektraGetDotUpdate.
placement 6-9 need to be executed after the hook.
an other way to do it would be only running 1-5 within elektraGetDoUpdate, then executing the hook, and then running 6-9, but there is the possibility that some of those needs to be executed before the hook or independent from the hook.
this was the only approach i could find without doing any bigger changes to kdbGet

[markus2330]

I think the problem is: this is called too late, you cannot call doUpdate after postprocessing of the keysets.

What about following logic:

elektraGetDoUpdate
hook MIDDLEGETSTORAGE
elektraGetDoUpdate2
elektraSplitGet // postprocessing
...
hook POSTGETSTORAGE

and spec will be called in MIDDLEGETSTORAGE?

[tom-wa]

elektraSplitMerge needs to be called before spec, and elektraSplitGet before elektraSplitMerge. So i guess i'd have to adjust elektraSplitGet but i'm not sure how to do the part with the syncbits

[tom-wa]

@markus2330 can you take a look at the currrent approach ?
it seems to work fine, but elektraSplitMerge is called twice. not sure how much bad the performance impact really is.

[markus2330]

I do not like the duplication of the code, can you add the NR_OF_PLUGINS as parameter?

[markus2330]

elektraSplitMerge should be quite cheap, but better to benchmark it. Actually, having a more efficient ksAppend is in TODO. (You can take advantage of that keysets are sorted when giving them together.) If it is expensive we could avoid it to be done twice if no such hook exists?

Doesn't it create a problem if a plugin removed some keys after position 6? (Because they would stay in the merged key set then).Don't you need to work on a duplicated keyset temporarily for the first elektraSplitMerge?

[markus2330]

But looks better now and less invasive, but there are still code duplication and formatting issues. Also the PR is too big, there are many unrelated parts here.

[tom-wa]

@markus2330 done.

[markus2330]

Thank you!