conditionals: now with topological sort #907
Conversation
| @@ -785,6 +787,129 @@ static CondResult evaluateKey (const Key * meta, const Key * suffixList, Key * p | |||
| return TRUE; | |||
| } | |||
|
|
|||
| static KeySet * getDependencies (const char * expr, Key * cur, Key * parentKey) | |||
| { | |||
| char * localExpr = strdup (expr); | |||
There was a problem hiding this comment.
please use elektraStrDup.
|
Please add unit tests. What else is missing? |
you are right. currently conditionals is the only plugin that benefits from it though, so let's keep it that way for now, i'll improve it and move it to libmeta later.
a lot of unit tests, +a few things to discuss: |
I think we should not do this for the next release anyway, but the idea is that it should be default when any calculations are involved. In longer term we should split the plugin to a validation and a calculation plugin. The calculation should be done at lookup time (see #867). Only the calculation needs correct ordering, for validation the order only matters for better error messages, but is not needed for correctness. |
|
I'll close it. Maybe we can continue this after Elektra 1.0. |
Purpose
Added topological sorting
Checklist