Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debian/clean file for deletions #3

Closed

Conversation

ahresse
Copy link
Contributor

@ahresse ahresse commented Jun 19, 2024

This is mostly a question of style but I find this way cleaner with the advantage to be data driven rather than using hard command lines.

To be data driven rather than using hard command lines.
Also remove dh_clean override.

Signed-off-by: Alexandre Esse <alexandre.esse@canonical.com>
@ahresse
Copy link
Contributor Author

ahresse commented Jun 19, 2024

@IsaacJT + @gehwolf for review.

@gehwolf
Copy link
Collaborator

gehwolf commented Jun 20, 2024

Thanks looks good from our side , we will integrate it first into main/debian.native and release it here on debian/main with the upcoming release.

@gehwolf
Copy link
Collaborator

gehwolf commented Jul 4, 2024

@ahresse we applied your changes to debian.native on the main branch. With the latest release for debian we published it for the debian/main.
Please have a look if you miss something otherwise we can close this as merged.

@ahresse
Copy link
Contributor Author

ahresse commented Jul 4, 2024

Merged as: 73b9857

Closing.

@ahresse ahresse closed this Jul 4, 2024
@ahresse ahresse deleted the debian/clean-file-introduction branch July 4, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants