Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: revert #13296 #13478

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Menu: revert #13296 #13478

merged 1 commit into from
Nov 20, 2018

Conversation

ziyoung
Copy link
Contributor

@ziyoung ziyoung commented Nov 20, 2018

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit 48937b3

https://deploy-preview-13478--element.netlify.com

@pengzzp
Copy link

pengzzp commented Nov 21, 2018

点击外部会让菜单栏缩进的问题 改了吗?

@ziyoung
Copy link
Contributor Author

ziyoung commented Nov 21, 2018

@pengzzp 已经把想 pr 重置了。今天发布新版本。

@ziyoung
Copy link
Contributor Author

ziyoung commented Nov 21, 2018

revert #13296
fix #13452

@holylovelqq
Copy link

因为项目中只用到了侧边垂直menu,就垂直menu来说,应该是回归到2.4.9版的功能了,就是把2.4.10新增的点击菜单外部,关闭当前子菜单的功能取消了?暂时来讲貌似只能这样了。
还是希望增加功能:当点击其他菜单时,当前打开的子菜单关闭。这里说的其他菜单包括其他拥有子菜单的菜单和没有子菜单的菜单,unique-opened没有实现当点击其他没有子菜单的菜单时,已经打开的子菜单关闭的功能,,这个在水平menu看起来应该比垂直更奇怪,2.4.10的初衷应该也是要修改这个吧。
期待下个版本修复

@z1900
Copy link

z1900 commented Nov 22, 2018

@chenziyue 开源出来给大家用已经很好了,你自己又写不出来,请不要抱怨,学会感恩

weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants