Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix 2.6.0 changelog error #15026

Merged
merged 3 commits into from
Apr 12, 2019
Merged

Conversation

iamkun
Copy link
Member

@iamkun iamkun commented Apr 9, 2019

fix #14848

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented Apr 9, 2019

Deploy preview for element ready!

Built with commit 823f55d

https://deploy-preview-15026--element.netlify.com

CHANGELOG.es.md Outdated
@@ -171,6 +171,7 @@
- Menu
- Añadido soporte para `el-menu-item` sin índice (by @georgyfarniev in #13298)
- Table
- Fix params order of row events (by @jikkai in #12086)
Copy link
Contributor

@breadadams breadadams Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix params order of row events (by @jikkai in #12086)
- Cambiar el orden de los parámetros enviados en los eventos de las filas (by @jikkai in #12086)

@breadadams
Copy link
Contributor

Imho this is a breaking change. As you have to update the relevant code in your project if you wish to use the latest version of Element. I see there's a Breaking changes section in the changelog, maybe you can move it there @iamkun?

@iamkun
Copy link
Member Author

iamkun commented Apr 9, 2019

@breadadams done!

Copy link
Contributor

@breadadams breadadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@iamkun iamkun added this to the 2.8.0 milestone Apr 10, 2019
@ziyoung ziyoung merged commit 9532975 into ElemeFE:dev Apr 12, 2019
@iamkun iamkun deleted the fix/change-log-2.6 branch May 6, 2019 07:02
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Add missing item to changelog (2.6.0)
4 participants