Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag demo has incorrect animation #2611

Closed
MattRix opened this issue Jan 26, 2017 · 3 comments
Closed

Tag demo has incorrect animation #2611

MattRix opened this issue Jan 26, 2017 · 3 comments

Comments

@MattRix
Copy link

MattRix commented Jan 26, 2017

In the demo for Tags, "Editing Dynamically", when you remove a tag, the correct item is removed, but the animation always plays on the last item on the list. It looks weird.
@erguotou520
Copy link

@Leopoldthecoder 目测是key没有设置为tag对象，而是使用的$index?

Leopoldthecoder added a commit to Leopoldthecoder/element that referenced this issue Jan 26, 2017
@Leopoldthecoder
Tag: fix a doc issue, fixed ElemeFE#2611
25bc5a5
@Leopoldthecoder
Copy link
Contributor

@erguotou520 是的。
@MattRix fixed in #2613

@erguotou520
Copy link

因为我发现这个问题跟我之前自己写的step组件的动效问题一样 😄
快过年了还在fix bug 辛苦了 👍

baiyaaaaa pushed a commit that referenced this issue Jan 29, 2017
@Leopoldthecoder @baiyaaaaa
Tag: fix a doc issue, fixed #2611 (#2613)
41c55ed
shangkai added a commit to shangkai/element that referenced this issue Feb 8, 2017
@shangkai
Merge commit 'f72cd1d2ddfb5afc16fc5180358eeabf94e90064' into dev
7d58363 
* commit 'f72cd1d2ddfb5afc16fc5180358eeabf94e90064': (22 commits)
  Update layout.md
  fix eslint error in gen-single-config.js
  AutoComplete: fix key enter (ElemeFE#2672)
  Example/table: fixed misspelling (ElemeFE#2673)
  Carousel: apply infinite sliding in non-card mode (ElemeFE#2622)
  Dialog: add title slot (ElemeFE#2657)
  update contributing guide (ElemeFE#2653)
  Scrollbar: return if component gets destroyed in mounted hook (ElemeFE#2588)
  Click event ElemeFE#2551 (ElemeFE#2614)
  update index translation (ElemeFE#2601)
  解决error变成null或者空的时候，validateState依然是error的问题。 (ElemeFE#2621)
  Popper: Fixing the rest part of wrong comments. (ElemeFE#2627)
  Update table.md (ElemeFE#2638)
  Added Greek
  Update page.json grammar (ElemeFE#2602)
  Tag: fix a doc issue, fixed ElemeFE#2611 (ElemeFE#2613)
  [tree]:add node-expand and node-collapse event
  [tree]:add node-expand and node-collapse event
  [tree]:add node-expand and node-collapse event
  [tree]:add node-open and node-close event
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MattRix @erguotou520 @Leopoldthecoder