Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date picker the readonly doesn't work #976

Closed
gil0mendes opened this issue Nov 10, 2016 · 1 comment
Closed

Date picker the readonly doesn't work #976

gil0mendes opened this issue Nov 10, 2016 · 1 comment
Assignees
@QingWei-Li
Labels
type: bug type: feature request

Comments

@gil0mendes
Copy link
Contributor

ElementUI version

1.0.0

OS/Browers version

macOS Sierra/Chrome 54.0.2840.71

Vue version

2.0.4

Reproduction Link

Example

What is Expected?

When the readonly prop is set to true the datepicker must be readonly and the value can't change.

What is actually happening?

The readonly prop doesn't change the element behaviour.

Suggestion

In order to follow the same pattern as the other input elements the readonly prop could be renamed to disabled.
QingWei-Li added a commit to QingWei-Li/element that referenced this issue Nov 11, 2016
@QingWei-Li
DatePicker: fix readonly, add disabled and editable, fixed ElemeFE#976
664fe2d
QingWei-Li added a commit to QingWei-Li/element that referenced this issue Nov 11, 2016
@QingWei-Li
DatePicker: fix readonly, add disabled and editable, fixed ElemeFE#976
a14a1ad
@gil0mendes
Copy link
Contributor Author

Huge thanks, this project is really amazing 😄👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QingWei-Li QingWei-Li

Labels
type: bug type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gil0mendes @furybean @QingWei-Li