Timeline: add timeline component #11736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for element ready! Built with commit a09b604 |
jikkai
changed the title
<el-timeline reverse>
<el-timeline-item>1</el-timeline-item>
<el-timeline-item>2</el-timeline-item>
<el-timeline-item>3</el-timeline-item>
</el-timeline>
|
|
这里 reverse 和实际排序没关系，只是能够反转原来的排序……感觉是和交互稿有点出入，稍后我确认下 |
|
排序行为修正，默认为正序排列 |
Leopoldthecoder
approved these changes
Jul 3, 2018
ziyoung
reviewed
Aug 6, 2018
packages/timeline/src/item.vue
Outdated
| class="el-timeline-item__node" | ||
| :class="[ | ||
| `el-timeline-item__node--${size}`, | ||
| `el-timeline-item__node--${type}` |
There was a problem hiding this comment.
这样写的话，可能会出现 el-timeline-item__node--undefined 这种类名的。不如改成以对象的形式绑定类名。
|
|
||
| watch: { | ||
| reverse: { | ||
| handler(newVal) { |
There was a problem hiding this comment.
我试了一下，直接调用 reverse 也是生效的。
this.$slots.default = [...this.$slots.default].reverse();
test/unit/specs/timeline.spec.js
Outdated
| }, true); | ||
|
|
||
| const timestampElm = vm.$el.querySelectorAll('.el-timeline-item__timestamp')[0]; | ||
| expect(toArray(timestampElm.classList)).to.contain('is-top'); |
There was a problem hiding this comment.
classList 有一个 contains 方法，直接返回布尔值了。不用再去转成数组了。
jikkai
added a commit
that referenced
this pull request
Aug 22, 2018
* Timeline: add timeline component * Timeline: add timeline component * Timeline: add test case * Timeline: fix icon class * Timeline: update docs * Timeline: fix test case * Timeline: remove pending attribute * Timeline: fix docs * Timeline: make reverse default to false * Timline: fix test case * Timeline: update element-ui.d.ts * Timeline: optimize code
jikkai
added a commit
that referenced
this pull request
Aug 28, 2018
* Timeline: add timeline component * Timeline: add timeline component * Timeline: add test case * Timeline: fix icon class * Timeline: update docs * Timeline: fix test case * Timeline: remove pending attribute * Timeline: fix docs * Timeline: make reverse default to false * Timline: fix test case * Timeline: update element-ui.d.ts * Timeline: optimize code
|
Timeline这个新特性很实用 👍 ，期待下个版本发布！ |
island205
pushed a commit
that referenced
this pull request
Jan 28, 2019
* Timeline: add timeline component * Timeline: add timeline component * Timeline: add test case * Timeline: fix icon class * Timeline: update docs * Timeline: fix test case * Timeline: remove pending attribute * Timeline: fix docs * Timeline: make reverse default to false * Timline: fix test case * Timeline: update element-ui.d.ts * Timeline: optimize code
island205
added a commit
that referenced
this pull request
Feb 1, 2019
* Table: fix params order of row events (#12086) * Timeline: add timeline component (#11736) * Timeline: add timeline component * Timeline: add timeline component * Timeline: add test case * Timeline: fix icon class * Timeline: update docs * Timeline: fix test case * Timeline: remove pending attribute * Timeline: fix docs * Timeline: make reverse default to false * Timline: fix test case * Timeline: update element-ui.d.ts * Timeline: optimize code
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
* Table: fix params order of row events (ElemeFE#12086) * Timeline: add timeline component (ElemeFE#11736) * Timeline: add timeline component * Timeline: add timeline component * Timeline: add test case * Timeline: fix icon class * Timeline: update docs * Timeline: fix test case * Timeline: remove pending attribute * Timeline: fix docs * Timeline: make reverse default to false * Timline: fix test case * Timeline: update element-ui.d.ts * Timeline: optimize code
lzq4047
pushed a commit
to lzq4047/element
that referenced
this pull request
May 22, 2020
* Table: fix params order of row events (ElemeFE#12086) * Timeline: add timeline component (ElemeFE#11736) * Timeline: add timeline component * Timeline: add timeline component * Timeline: add test case * Timeline: fix icon class * Timeline: update docs * Timeline: fix test case * Timeline: remove pending attribute * Timeline: fix docs * Timeline: make reverse default to false * Timline: fix test case * Timeline: update element-ui.d.ts * Timeline: optimize code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.