Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: fix click el-submenu trigger childMenu pop again bug #14443

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

PanJiaChen
Copy link
Contributor

@PanJiaChen PanJiaChen commented Feb 21, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

The showTimeout duration of popupMenu does not need to be the same as inlineMenu.
If it
set too long, it will cause the submenu pop again bug when you quickly click on the menu.

submenu

To fix #12512

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit 7cd6cee

https://deploy-preview-14443--element.netlify.com

@iamkun iamkun requested a review from ziyoung March 4, 2019 07:31
@ziyoung ziyoung added this to the 2.7.0 milestone Mar 4, 2019
@trylovetom
Copy link

@PanJiaChen 剛剛測試了下,在移動端(iPad)問題還是存在

@PanJiaChen
Copy link
Contributor Author

@PanJiaChen 你是怎么测得?拉了我的分支?还是自己改了代码?

@trylovetom
Copy link

@PanJiaChen @element-bot 部署了一個 preview 版本

@iamkun
Copy link
Member

iamkun commented Mar 19, 2019

@ziyoung ziyoung merged commit 56e3e1f into ElemeFE:dev Mar 26, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] [navMenu] click el-submenu trigger childMenu layer pop again
5 participants