Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber: add step-strictly attribute #15050

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

luckyCao
Copy link
Contributor

add multiple-of-step attribute
Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented Apr 10, 2019

Deploy preview for element ready!

Built with commit 3f0780d

https://deploy-preview-15050--element.netlify.com

@island205
Copy link
Contributor

doc for multiple-of-step attribute?

@luckyCao
Copy link
Contributor Author

luckyCao commented Apr 10, 2019

@island205 review 一下,multiple-of-step 这个属性名称 ok 的话,我现在加上

@luckyCao luckyCao force-pushed the feature/input-number-step branch 3 times, most recently from 5638c34 to 6487ed0 Compare April 10, 2019 09:10
export default {
data() {
return {
num3: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以直接使用 num,这个文档的其他的地方也可以改一下。

@@ -69,6 +69,26 @@ Allows you to define incremental steps.
```
:::

### Multiple of Step

:::demo The `multiple-of-step` attribute accepts a `boolean`. if this attribute is `true`, input value can not be anything but multiple of step.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about: "input value can only be multiples of step."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, thanks

@ziyoung
Copy link
Contributor

ziyoung commented Apr 18, 2019

命名为 step-strictly

@luckyCao luckyCao added this to the 2.8.0 milestone Apr 23, 2019
@ziyoung ziyoung changed the title InputNumber: add multiple-of-step attribute InputNumber: add step-strictly attribute Apr 23, 2019
@ziyoung ziyoung merged commit 1fe6849 into ElemeFE:dev Apr 23, 2019
FAKER-A pushed a commit to FAKER-A/element that referenced this pull request May 7, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants