Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider: add divider component #15055

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Divider: add divider component #15055

merged 2 commits into from
Apr 19, 2019

Conversation

island205
Copy link
Contributor

@island205 island205 commented Apr 10, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented Apr 10, 2019

Deploy preview for element ready!

Built with commit 2e03c0f

https://deploy-preview-15055--element.netlify.com

@island205 island205 changed the title Divider: add divider component [WIP]Divider: add divider component Apr 10, 2019
@island205 island205 added this to the 2.8.0 milestone Apr 11, 2019
@wacky6
Copy link
Contributor

wacky6 commented Apr 12, 2019

我觉得这个可以直接写成一个 functional component

@island205
Copy link
Contributor Author

我觉得这个可以直接写成一个 functional component

改了

@island205 island205 force-pushed the feature/divider branch 2 times, most recently from 19ea7fb to a3a1ab3 Compare April 18, 2019 09:45
@island205 island205 changed the title [WIP]Divider: add divider component Divider: add divider component Apr 18, 2019
@ziyoung ziyoung merged commit 128feba into ElemeFE:dev Apr 19, 2019
@jw-foss
Copy link
Contributor

jw-foss commented Apr 25, 2019

Minor:
是否在下次更新时, 能够提供让用户自己设置位置百分比的 API ? 有时可能 "position" 会不够用

@island205
Copy link
Contributor Author

@JeremyWuuuuu PR welcome

FAKER-A pushed a commit to FAKER-A/element that referenced this pull request May 7, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants