Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel: add direction attribute and support vertical direction #15122

Merged
merged 4 commits into from
Apr 19, 2019

Conversation

ziyoung
Copy link
Contributor

@ziyoung ziyoung commented Apr 15, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@ziyoung ziyoung added the kiwi label Apr 15, 2019
@element-bot
Copy link
Member

element-bot commented Apr 15, 2019

Deploy preview for element ready!

Built with commit a7fb78c

https://deploy-preview-15122--element.netlify.com

@ziyoung ziyoung added this to the 2.8.0 milestone Apr 15, 2019
@beautycss
Copy link

@element-bot so when will the 2.8.0 release version be deployed?
look forward to use the "direction" feature.

@ziyoung
Copy link
Contributor Author

ziyoung commented Apr 18, 2019

@element-bot so when will the 2.8.0 release version be deployed?
look forward to use the "direction" feature.

We will release 2.8 next week.

@ziyoung ziyoung merged commit 2a65c9d into ElemeFE:dev Apr 19, 2019
@ziyoung ziyoung deleted the carousel branch April 19, 2019 07:51
FAKER-A pushed a commit to FAKER-A/element that referenced this pull request May 7, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants