Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller size for components (#14850) #15644

Closed
wants to merge 13 commits into from
Closed

Smaller size for components (#14850) #15644

wants to merge 13 commits into from

Conversation

amedora
Copy link
Contributor

@amedora amedora commented May 21, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

close #14850

Sub PRs

@element-bot
Copy link
Member

element-bot commented May 21, 2019

Deploy preview for element ready!

Built with commit e500a80

https://deploy-preview-15644--element.netlify.com

@amedora amedora changed the title [WIP] Smaller size for components (#14850) Smaller size for components (#14850) May 23, 2019
@ChuckFields
Copy link
Contributor

@amedora This is awesome! I took a look at the preview and I have a few comments.

  • The round compact button in the preview has size="Compact" instead of size="compact" so it looks the same as default.
  • An el-radio-group with el-radio-buttons does not work with compact, however it does work if you use el-radios instead of el-radio-buttons.
  • How hard would it be to make the el-date-pickers popup panel reflective of it's size?
  • How hard would it be to make the el-options inside of el-selects reflective of it's size?

@amedora
Copy link
Contributor Author

amedora commented May 24, 2019

@ChuckFields thanks for your feedbacks.

  • The round compact button in the preview has size="Compact" instead of size="compact" so it looks the same as default.
  • An el-radio-group with el-radio-buttons does not work with compact, however it does work if you use el-radios instead of el-radio-buttons.

oops, those were my mistake. fixed them now.

  • How hard would it be to make the el-date-pickers popup panel reflective of it's size?
  • How hard would it be to make the el-options inside of el-selects reflective of it's size?

Both doesn't have size option so there will be a lot of things to do.

@ChuckFields
Copy link
Contributor

@amedora Okay no problem, those last 2 are just nice-to-haves.

@wacky6
Copy link
Contributor

wacky6 commented May 30, 2019

@amedora There are conflicts in *.md files, please take a look.

This feature looks good, we will try to include it in next release.

@wacky6 wacky6 added this to the 2.10.0 milestone May 30, 2019
@amedora
Copy link
Contributor Author

amedora commented May 30, 2019

@wacky6 Thanks! Now rebased to current dev branch.

@island205
Copy link
Contributor

  1. please resolve conflicts
  2. spliting this PR to small PR which just modify one component is more readable.

@island205 island205 self-assigned this Jun 4, 2019
@amedora
Copy link
Contributor Author

amedora commented Jun 4, 2019

  1. please resolve conflicts
  2. spliting this PR to small PR which just modify one component is more readable.

Sure. I will do that later 👍

@amedora amedora changed the title Smaller size for components (#14850) [WIP] Smaller size for components (#14850) Jun 4, 2019
This was referenced Jun 4, 2019
@amedora amedora changed the title [WIP] Smaller size for components (#14850) Smaller size for components (#14850) Jun 4, 2019
@island205
Copy link
Contributor

I am very sorry, Refer to our designer's opinion, we have no plan to support this at this time.

@island205 island205 closed this Jun 20, 2019
@island205 island205 removed this from the 2.10.0 milestone Jun 20, 2019
@amedora
Copy link
Contributor Author

amedora commented Jun 20, 2019

@island205 I see. Thanks for taking care of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] A smaller size for components
5 participants