Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scroll duration #18126

Closed

Conversation

SunGuoQiang123
Copy link

  1. add scroll duration props
  2. fix scrollTop compatible bugs: sometimes should get scrollTop by document.body.scrollTop and sometimes by document.documentElement.scrollTop
  3. change toggle backTop btn from v-if to v-show, maybe this toggle may occur often

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented Nov 20, 2019

Deploy preview for element ready!

Built with commit b8f9e7c

https://deploy-preview-18126--element.netlify.com

@weituotian
Copy link

it is good!i agree

@stale
Copy link

stale bot commented Jun 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 4, 2021
@stale stale bot closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants