Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "DatePicker: input display style changes to block, fixed #2018" #2038

Merged
merged 1 commit into from Dec 28, 2016

Conversation

baiyaaaaa
Copy link
Contributor

This reverts commit b3095a7.

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's Contributing Guide.
  • Make sure you are merging your commits to dev branch.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@QingWei-Li
Copy link
Contributor

歪?

@baiyaaaaa
Copy link
Contributor Author

按照原生的控件看输入框应该是 inline-block 才对,应该修改的是 input 的为 inline-block
换个角度看,像日期这种输入框肯定不是用户默认想要的,因为值的长度是固定的,有一个默认能比较适合的展示 value 的宽度肯定是更好的选择。
image

@QingWei-Li
Copy link
Contributor

所以 select 也要改咯?

@baiyaaaaa
Copy link
Contributor Author

滋瓷 select 和 input 改过来

@Leopoldthecoder Leopoldthecoder merged commit 7eb8a19 into ElemeFE:1.1 Dec 28, 2016
@baiyaaaaa baiyaaaaa deleted the 1.1 branch March 4, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants