Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add right nav #21026

Closed
wants to merge 3 commits into from
Closed

Conversation

liushuiyuan001
Copy link

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented May 26, 2021

✔️ Deploy Preview for element ready!

🔨 Explore the source changes: 85a01d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/element/deploys/60b71ed7e9d64700089b1604

😎 Browse the preview: https://deploy-preview-21026--element.netlify.app/

@liushuiyuan001
Copy link
Author

@JeremyWuuuuu

Can I copy your code and change it a bit? If not, I will cancel. I hope to have this feature in version 2x
Below is your pr
element-plus/element-plus#1341

@liushuiyuan001
Copy link
Author

liushuiyuan001 commented May 27, 2021

@cs1707 Can the pr be merged?

@jw-foss
Copy link
Contributor

jw-foss commented May 27, 2021

@JeremyWuuuuu

Can I copy your code and change it a bit? If not, I will cancel. I hope to have this feature in version 2x
Below is your pr
element-plus/element-plus#1341

This work is done by @Ryan2128, you might mention the reference in the code. That'd be ok to us.

@liushuiyuan001
Copy link
Author

@JeremyWuuuuu
Can I copy your code and change it a bit? If not, I will cancel. I hope to have this feature in version 2x
Below is your pr
element-plus/element-plus#1341

This work is done by @Ryan2128, you might mention the reference in the code. That'd be ok to us.

OK,Thx.
@Ryan2128. Can I copy your code ?

@cs1707
Copy link
Contributor

cs1707 commented May 28, 2021

@cs1707 Can the pr be merged?

Dear @liushuiyuan001 . Thanks for your contribution.
Some styles need to be modified.
image

@liushuiyuan001
Copy link
Author

@cs1707 Can the pr be merged?

Dear @liushuiyuan001 . Thanks for your contribution.
Some styles need to be modified.
image

OK.I will fix

@liushuiyuan001
Copy link
Author

@media (max-width: 1490px) {  
 .right-nav {    
   display: none; 
 }
}

@cs1707 The whole style seems to have some problems. I can only fit the big screen.It's OK? Otherwise the content will be covered.

@cs1707
Copy link
Contributor

cs1707 commented Jun 1, 2021

@media (max-width: 1490px) {  
 .right-nav {    
   display: none; 
 }
}

@cs1707 The whole style seems to have some problems. I can only fit the big screen.It's OK? Otherwise the content will be covered.

@media (max-width: 1490px) {  
 .right-nav {    
   display: none; 
 }
}

@cs1707 The whole style seems to have some problems. I can only fit the big screen.It's OK? Otherwise the content will be covered.

I think the style still needs to be optimized. eg: position, scrollbar. And the error reporting in the console needs to be fixed.

@liushuiyuan001
Copy link
Author

@cs1707
I just fix error reporting and fix style.It' OK ? What should I do ?

@liushuiyuan001 liushuiyuan001 closed this by deleting the head repository May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants