Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affix: Add component Affix #21192

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Affix: Add component Affix #21192

wants to merge 3 commits into from

Conversation

midcu
Copy link

@midcu midcu commented Jul 28, 2021

Please make sure these boxes are checked before submitting your PR, thank you!
fixed #13569 #15679 #16169 #3404

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented Jul 28, 2021

✔️ Deploy Preview for element ready!

🔨 Explore the source changes: c506552

🔍 Inspect the deploy log: https://app.netlify.com/sites/element/deploys/610270413b545b0007ec04e8

😎 Browse the preview: https://deploy-preview-21192--element.netlify.app/

@midcu midcu closed this Jul 29, 2021
@midcu midcu reopened this Jul 29, 2021
@cs1707
Copy link
Contributor

cs1707 commented Jul 29, 2021

@midcu midcu closed this Jul 29, 2021
@midcu midcu reopened this Jul 29, 2021
@midcu
Copy link
Author

midcu commented Jul 29, 2021

It doesn't work as expected.
https://deploy-preview-21192--element.netlify.app/?utm_source=github&utm_campaign=bot_dp#/zh-CN/component/affix

I forgot to add it to the components.json. Now it works!

@cs1707 cs1707 self-assigned this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Why is there no affix component? Your sample code is clearly implemented
3 participants