Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make it sass compatible #21811

Closed
wants to merge 1 commit into from

Conversation

KazuAlex
Copy link

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

This PR is a rework of #21019 that make theme-chalk node-sass and sass compatible without removing current node-sass

@KazuAlex
Copy link
Author

Up!

@KazuAlex
Copy link
Author

KazuAlex commented Jun 3, 2022

What's up ?

@KazuAlex
Copy link
Author

Are you alive ?

@jdinartejesus
Copy link

I would love to see this being merged, @KazuAlex. Anything we can do to push this?

@KazuAlex
Copy link
Author

KazuAlex commented Aug 5, 2022

No idea. I just do the work but element team seems to have abandoned this repo ¯\_(ツ)_/¯

@ryougifujino
Copy link

ryougifujino commented Sep 19, 2022

This should be merged in order to make this repo work with the latest node.

@KazuAlex
Copy link
Author

I'll try to ping people...
@xinguanhua @cs1707 😘

@xinguanhua
Copy link
Collaborator

related update in v2.15.7 occurred some compatibility problems, so reversed in v2.15.8, will be fixed in v2.16.0 soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants