Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: add initialIndex prop #22346

Merged
merged 1 commit into from Feb 9, 2023
Merged

Image: add initialIndex prop #22346

merged 1 commit into from Feb 9, 2023

Conversation

inkroom
Copy link
Contributor

@inkroom inkroom commented Jan 6, 2023

custom image preview image index

close #21657
close #20026

inkroom added a commit to inkroom/image-pages that referenced this pull request Feb 6, 2023
这是element不完善的地方,我给提了pr(ElemeFE/element#22346
@xinguanhua
Copy link
Collaborator

@inkroom 建议再兼容一下原先的 src 相关逻辑

@inkroom
Copy link
Contributor Author

inkroom commented Feb 9, 2023

@inkroom 建议再兼容一下原先的 src 相关逻辑

没懂要怎么改。能细说一下是哪一块逻辑吗?

@xinguanhua
Copy link
Collaborator

@inkroom 首先, | 是filter,你的提交会导致报错。我会合并当前pr,然后再提交一个commit处理一下存在的问题。

@xinguanhua xinguanhua merged commit e7d6893 into ElemeFE:dev Feb 9, 2023
@xinguanhua
Copy link
Collaborator

@inkroom 你好,很感谢你以pr的方式,为element-ui组件库的完善贡献了一份力量。element-ui有一份礼物将会寄给你,希望能够提供git账户名,寄件地址及联系方式,可以发送邮件到 xinguanhua@gmail.com

@inkroom
Copy link
Contributor Author

inkroom commented Feb 21, 2023

xinguanhua@gmail.com

好的,邮件已发送,请查收

@inkroom
Copy link
Contributor Author

inkroom commented Feb 21, 2023

@inkroom 你好,很感谢你以pr的方式,为element-ui组件库的完善贡献了一份力量。element-ui有一份礼物将会寄给你,希望能够提供git账户名,寄件地址及联系方式,可以发送邮件到 xinguanhua@gmail.com

好的,邮件已发送,请查收

@lufei9527
Copy link

image-viewer组件中给img加了一个referrerpolicy:no-referrer,导致项目里预览图显示403,因为我们公司的图片都加了防盗链,这个怎么解决?

Simon-He95 pushed a commit to Simon-He95/element that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants